Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): add full-width numbers support for Time, Date, DateTime, DateRange #1043

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

rikusen0335
Copy link
Contributor

@rikusen0335 rikusen0335 commented Feb 10, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #884

This PR implements full-width to half-width preprocessor into time, or datetime or almost similar masks.

Please see issue page for more detail

What is the new behaviour?

Above masks will have full-width to half-width preprocessor.

Implementation

  • Moved createFullWidthToHalfWidthPreprocessor from projects/kit/src/lib/masks/number/processors to projects/kit/src/lib/processors (also tests)
  • Added createFullWidthToHalfWidthPreprocessor to Time, Date, DateTime, DateRange masks
  • Added e2e tests for Time, Date, DateTime, DateRange masks

@rikusen0335
Copy link
Contributor Author

@nsbarsukov
Made a tests for Date or Time related, please review this when you have a time :)

@nsbarsukov nsbarsukov changed the title Add full-width numbers support for Time, Date, DateTime, DateRange feat(kit): add full-width numbers support for Time, Date, DateTime, DateRange Feb 12, 2024
@rikusen0335
Copy link
Contributor Author

Okay, now I added colon convert preprocessor to Time and DateTime masks.

@nsbarsukov nsbarsukov added the community contribution This issue was closed by a PR from the community label Feb 19, 2024
@nsbarsukov nsbarsukov merged commit 434c9c5 into taiga-family:main Feb 19, 2024
31 checks passed
@nsbarsukov
Copy link
Member

@rikusen0335 Thanks ❤️

@rikusen0335
Copy link
Contributor Author

Congrats! 🎉

@rikusen0335 rikusen0335 deleted the feat/884_full-width-test branch February 19, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - Add full-width numbers support for Time, Date, DateTime, DateRange
2 participants