generated from Tinkoff/angular-open-source-starter
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): add full-width numbers support for Time
, Date
, DateTime
, DateRange
#1043
Merged
nsbarsukov
merged 5 commits into
taiga-family:main
from
rikusen0335:feat/884_full-width-test
Feb 19, 2024
Merged
feat(kit): add full-width numbers support for Time
, Date
, DateTime
, DateRange
#1043
nsbarsukov
merged 5 commits into
taiga-family:main
from
rikusen0335:feat/884_full-width-test
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
@nsbarsukov |
nsbarsukov
requested changes
Feb 12, 2024
projects/demo-integrations/src/tests/kit/time/time-fullwidth-to-halfwidth.cy.ts
Show resolved
Hide resolved
nsbarsukov
changed the title
Add full-width numbers support for Time, Date, DateTime, DateRange
feat(kit): add full-width numbers support for Feb 12, 2024
Time
, Date
, DateTime
, DateRange
Okay, now I added colon convert preprocessor to |
nsbarsukov
approved these changes
Feb 19, 2024
nsbarsukov
added
the
community contribution
This issue was closed by a PR from the community
label
Feb 19, 2024
@rikusen0335 Thanks ❤️ |
Congrats! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #884
This PR implements full-width to half-width preprocessor into time, or datetime or almost similar masks.
Please see issue page for more detail
What is the new behaviour?
Above masks will have full-width to half-width preprocessor.
Implementation
createFullWidthToHalfWidthPreprocessor
fromprojects/kit/src/lib/masks/number/processors
toprojects/kit/src/lib/processors
(also tests)createFullWidthToHalfWidthPreprocessor
toTime
,Date
,DateTime
,DateRange
masksTime
,Date
,DateTime
,DateRange
masks