Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kit): DateTime supports configurable parameter dateTimeSeparator #1143

Merged
merged 23 commits into from
Mar 27, 2024
Merged

feat(kit): DateTime supports configurable parameter dateTimeSeparator #1143

merged 23 commits into from
Mar 27, 2024

Conversation

KrollikRoddzer
Copy link
Contributor

Closes #343

Done:

  1. Added dateTimeSeparator parameter for DateTime
  2. Added documentation for dateTimeSeparator
  3. Created tests for dateTimeSeparator

@KrollikRoddzer KrollikRoddzer changed the title feat(kit): DateTime support configurable parameter dateTimeSeparator feat(kit): DateTime supports configurable parameter dateTimeSeparator Mar 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit de969f9):

https://maskito--pr1143-date-time-separator-dsj0kvn2.web.app

(expires Thu, 28 Mar 2024 07:49:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 61e4dea776cbea516b68c67840913d2edd88bb90

nsbarsukov
nsbarsukov reviewed Mar 14, 2024
View reviewed changes
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts Outdated Show resolved Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts Outdated Show resolved Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts Outdated Show resolved Hide resolved
projects/demo/src/pages/kit/date-time/date-time-mask-doc.component.ts Outdated Show resolved Hide resolved
projects/demo/src/pages/kit/date-time/date-time-mask-doc.template.html Outdated Show resolved Hide resolved
projects/demo/src/pages/kit/date-time/date-time-mask-doc.template.html Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/date-time/date-time-mask.ts Show resolved Hide resolved
projects/kit/src/lib/masks/date-time/postprocessors/min-max-date-time-postprocessor.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/date-time/utils/parse-date-time-string.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/utils/date/validate-date-string.ts Outdated Show resolved Hide resolved
@KrollikRoddzer
Copy link
Contributor Author

Add unit tests

@KrollikRoddzer
Copy link
Contributor Author

Change to object in toDateString

nsbarsukov
nsbarsukov requested changes Mar 20, 2024
View reviewed changes
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts Outdated Show resolved Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts Outdated Show resolved Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts Outdated Show resolved Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts Outdated Show resolved Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/date-time/postprocessors/min-max-date-time-postprocessor.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/date-time/tests/date-time-separator.spec.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/date-time/tests/date-time-separator.spec.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/date-time/tests/date-time-separator.spec.ts Outdated Show resolved Hide resolved
projects/kit/src/lib/masks/date-time/tests/date-time-separator.spec.ts Outdated Show resolved Hide resolved
KrollikRoddzer and others added 19 commits March 26, 2024 19:54
@KrollikRoddzer
feat(kit): added dateTimeSeparator for DateTime
f2bb276
@KrollikRoddzer
fix(demo): resolved conflict in date-time-mask-example
c4ea092
@KrollikRoddzer
test(demo-integrations): added tests for dateTimeSeparator
f0a3a34
@KrollikRoddzer
docs(demo): changed doc text for dateTimeSeparator
1473259
@KrollikRoddzer
docs(demo): changed name of example files in exmaple comp
daebbfe
@KrollikRoddzer
refactor(demo-integrations): refactored date time separator tests
6661ef8
@KrollikRoddzer
refactor(demo): changed docs text for date time separtor
fd5e11a
@KrollikRoddzer
test(kit): added unit tests for date time separator
b46337e
@KrollikRoddzer
refactor(demo-integrations): refactored tests for date time separator
66c8f6b
@KrollikRoddzer
refactor: dateTimeSeparator is required in min max date time postprec…
4067c52 
…essor
@KrollikRoddzer
refactor: changed signature of parseDateTimeString,takes val and obj …
228e553 
…with dateMode and dateTimeSep
@KrollikRoddzer
refactor(kit): changed signature of validate date string, it takes to…
a777cd2 
… args obj and obj
@KrollikRoddzer
refactor(demo-integrations): refactored e2e tests for dateTimeSeparator
9a45155
@KrollikRoddzer
refactor(kit): refactored min max date time postptocessor
c4abfdd
@KrollikRoddzer
refactor(kit): changed import for date time separator tests
0b33c6c
@KrollikRoddzer
refactor(kit): refactored unit tests for date time separator
e3bb4f8
@KrollikRoddzer
refactor(kit): added overload for to date string method
3f54f69
@taiga-family-bot @KrollikRoddzer
chore: apply changes after linting [bot]
3cd7273
@KrollikRoddzer
test(kit): refactored tests
15cc55d
@github-actions github-actions bot added the ready to merge ready label Mar 27, 2024
@nsbarsukov nsbarsukov merged commit ec86284 into main Mar 27, 2024
31 checks passed
@nsbarsukov nsbarsukov deleted the date-time-separator branch March 27, 2024 08:06
@taiga-family-bot taiga-family-bot mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsbarsukov nsbarsukov nsbarsukov approved these changes

Assignees

@KrollikRoddzer KrollikRoddzer

Labels
ready to merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 - DateTime add configurable parameter dateTimeSeparator (or just separator)
3 participants
@KrollikRoddzer @nsbarsukov @taiga-family-bot