generated from Tinkoff/angular-open-source-starter
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): DateTime
supports configurable parameter dateTimeSeparator
#1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrollikRoddzer
changed the title
feat(kit):
feat(kit): Mar 13, 2024
DateTime
support configurable parameter dateTimeSeparator
DateTime
supports configurable parameter dateTimeSeparator
Visit the preview URL for this PR (updated for commit de969f9): https://maskito--pr1143-date-time-separator-dsj0kvn2.web.app (expires Thu, 28 Mar 2024 07:49:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 61e4dea776cbea516b68c67840913d2edd88bb90 |
nsbarsukov
reviewed
Mar 14, 2024
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/pages/kit/date-time/date-time-mask-doc.component.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/pages/kit/date-time/date-time-mask-doc.template.html
Outdated
Show resolved
Hide resolved
projects/demo/src/pages/kit/date-time/date-time-mask-doc.template.html
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/date-time/postprocessors/min-max-date-time-postprocessor.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/date-time/utils/parse-date-time-string.ts
Outdated
Show resolved
Hide resolved
Add unit tests |
Change to object in toDateString |
nsbarsukov
requested changes
Mar 20, 2024
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/date-time/postprocessors/min-max-date-time-postprocessor.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/date-time/tests/date-time-separator.spec.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/date-time/tests/date-time-separator.spec.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/date-time/tests/date-time-separator.spec.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/date-time/tests/date-time-separator.spec.ts
Outdated
Show resolved
Hide resolved
nsbarsukov
reviewed
Mar 20, 2024
KrollikRoddzer
force-pushed
the
date-time-separator
branch
from
March 22, 2024 14:02
0d0e789
to
728621e
Compare
nsbarsukov
reviewed
Mar 26, 2024
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Show resolved
Hide resolved
projects/demo-integrations/src/tests/kit/date-time/date-time-date-time-separator.cy.ts
Outdated
Show resolved
Hide resolved
projects/kit/src/lib/masks/date-time/utils/is-date-time-string-complete.ts
Outdated
Show resolved
Hide resolved
…with dateMode and dateTimeSep
… args obj and obj
KrollikRoddzer
force-pushed
the
date-time-separator
branch
from
March 26, 2024 16:54
661f7fd
to
d730b64
Compare
nsbarsukov
approved these changes
Mar 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343
Done:
dateTimeSeparator
parameter forDateTime
dateTimeSeparator
dateTimeSeparator