Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add type=button to textfield for ignore submit event #8455

Merged

Conversation

denzo1993
Copy link
Contributor

@denzo1993 denzo1993 commented Aug 11, 2024

При обнулении значения в textfield, происходит submit формы. Добавил type="button", чтобы этого не происходило

Copy link

lumberjack-bot bot commented Aug 11, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Aug 11, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
277.92KB +10%
demo/browser/vendor.(hash).js
216.27KB +10%
demo/browser/runtime.(hash).js
41.19KB +10%
demo/browser/styles.(hash).css
11.55KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +4B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
6.67MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode
Copy link
Member

splincode commented Aug 11, 2024

@denzo1993 please, run

npm run prettier -- --write

@denzo1993
Copy link
Contributor Author

denzo1993 commented Aug 11, 2024

@splincode Done, but nothing changed 🙃

@splincode
Copy link
Member

@denzo1993 are you sure?
image

@splincode splincode changed the title feature: Add type="button" to textarea clear button fix(core): add type=button to textfield for ignore submit event Aug 12, 2024
@splincode splincode merged commit 4700e5d into taiga-family:main Aug 12, 2024
28 of 29 checks passed
This was referenced Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants