Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): prevent add/remove suffixes while InputNumber is readonly #8568

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Andronzi
Copy link
Contributor

Closes #8528

Copy link

lumberjack-bot bot commented Aug 16, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.05%. Comparing base (43c0ebb) to head (2950aeb).
Report is 1347 commits behind head on main.

Files Patch % Lines
.../components/input-number/input-number.component.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8568      +/-   ##
==========================================
- Coverage   70.19%   67.05%   -3.14%     
==========================================
  Files        1460     1171     -289     
  Lines       15934    15047     -887     
  Branches     2292     2052     -240     
==========================================
- Hits        11185    10090    -1095     
- Misses       4369     4807     +438     
+ Partials      380      150     -230     
Flag Coverage Δ
summary 67.05% <50.00%> (-3.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode
Copy link
Member

@Andronzi could you add backport to v3.x?

@splincode splincode added the v4 4.0 candidate label Aug 16, 2024
Copy link

bundlemon bot commented Aug 16, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
280.68KB +10%
demo/browser/vendor.(hash).js
216.25KB +10%
demo/browser/runtime.(hash).js
41.52KB +10%
demo/browser/styles.(hash).css
11.56KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
6.79MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Andronzi
Copy link
Contributor Author

@Andronzi could you add backport to v3.x?

It's ready. Forked just a main, so pushed v3 branch to my fork from remote :-)

@waterplea waterplea merged commit 7a58d78 into taiga-family:main Aug 19, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 4.0 candidate
Development

Successfully merging this pull request may close these issues.

🐞 - InputNumber should not add/remove suffixes if readOnly=true
3 participants