Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): BadgedContent icon is positioned incorrectly when it's shown with a delay #8932

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mohan-mu
Copy link
Contributor

@mohan-mu mohan-mu commented Sep 10, 2024

Close #8907

Copy link

lumberjack-bot bot commented Sep 10, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.68%. Comparing base (43c0ebb) to head (4a26b1a).
Report is 1573 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8932      +/-   ##
==========================================
+ Coverage   70.19%   75.68%   +5.49%     
==========================================
  Files        1460     1216     -244     
  Lines       15934    19068    +3134     
  Branches     2292     2091     -201     
==========================================
+ Hits        11185    14432    +3247     
- Misses       4369     4592     +223     
+ Partials      380       44     -336     
Flag Coverage Δ
summary 75.68% <100.00%> (+5.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode changed the title fix(kit): BadgedContent: icon is positioned incorrectly when it's sho… fix(kit): BadgedContent: icon is positioned incorrectly when it's shown with a delay Sep 10, 2024
@splincode splincode changed the title fix(kit): BadgedContent: icon is positioned incorrectly when it's shown with a delay fix(kit): BadgedContent icon is positioned incorrectly when it's shown with a delay Sep 10, 2024
mdlufy
mdlufy previously approved these changes Sep 10, 2024
Copy link

bundlemon bot commented Sep 10, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
283.4KB (+20B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.48KB +10%
demo/browser/runtime.(hash).js
42.17KB +10%
demo/browser/styles.(hash).css
12.81KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change +20B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.99MB (+20B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy dismissed their stale review September 10, 2024 08:40

Just a moment

@mdlufy mdlufy merged commit 96c476b into taiga-family:main Sep 10, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - v4 BadgedContent: icon is positioned incorrectly when it's shown with a delay
4 participants