Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Textfield has change detection problems for [filler] #9243

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

nsbarsukov
Copy link
Member

Fixes #9238

Copy link

lumberjack-bot bot commented Sep 27, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 27, 2024
Copy link
Contributor

github-actions bot commented Sep 27, 2024

Visit the preview URL for this PR (updated for commit 82e523c):

https://taiga-previews--pr9243-textfield-filler-cd-rsfggznm.web.app

(expires Tue, 01 Oct 2024 09:33:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Sep 27, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
288.25KB (+78B +0.03%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
247.14KB +10%
demo/browser/runtime.(hash).js
42.8KB +10%
demo/browser/styles.(hash).css
16.17KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +78B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.18MB (+78B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode
Copy link
Member

Could you add cypress component test?

@nsbarsukov
Copy link
Member Author

nsbarsukov commented Sep 27, 2024

Could you add cypress component test?

I am not sure that this case could be covered by simple test with some assertions.
It should be at least screenshot test. Screenshot testing is not supported by OUR Cypress component testing.

@splincode splincode enabled auto-merge (squash) September 30, 2024 09:47
@splincode splincode merged commit a45df07 into main Sep 30, 2024
27 checks passed
@splincode splincode deleted the textfield-filler-cd-bug branch September 30, 2024 09:55
This was referenced Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

🐞 - Textfield has change detection problems for filler
3 participants