Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add dialog-factory #9446

Merged
merged 4 commits into from
Oct 18, 2024
Merged

feat(core): add dialog-factory #9446

merged 4 commits into from
Oct 18, 2024

Conversation

MillerSvt
Copy link
Collaborator

Fixes #

@MillerSvt MillerSvt self-assigned this Oct 11, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 11, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@MillerSvt MillerSvt marked this pull request as draft October 11, 2024 07:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit b97d4f8):

https://taiga-previews--pr9446-dialog-factory-dsonrnuh.web.app

(expires Thu, 17 Oct 2024 10:58:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 11, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 295.03KB (+51B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 254.86KB +10%
✅ demo/browser/runtime.(hash).js
 43.07KB +10%
✅ demo/browser/styles.(hash).css
 16.27KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +54B +0.01%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.14MB (-218B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@MillerSvt MillerSvt marked this pull request as ready for review October 11, 2024 09:50
@MillerSvt MillerSvt force-pushed the dialog-factory branch 2 times, most recently from 8865729 to 44ab3f0 Compare October 14, 2024 09:05
@waterplea waterplea merged commit f507d2e into main Oct 18, 2024
28 checks passed
@waterplea waterplea deleted the dialog-factory branch October 18, 2024 11:12
@taiga-family-bot taiga-family-bot mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@mdlufy mdlufy Awaiting requested review from mdlufy

Assignees

@MillerSvt MillerSvt

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MillerSvt @waterplea @splincode @nsbarsukov @vladimirpotekhin