Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-mobile): ResponsiveDialog add new service and refactor SheetDialog to new spec #9459

Merged
merged 23 commits into from
Oct 17, 2024

Conversation

waterplea
Copy link
Collaborator

Fixes #8945

Copy link

lumberjack-bot bot commented Oct 11, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Oct 11, 2024

Visit the preview URL for this PR (updated for commit 2c82ee4):

https://taiga-previews--pr9459-sheet-9atylraf.web.app

(expires Thu, 17 Oct 2024 10:13:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 11, 2024

BundleMon

Files updated (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
255.06KB (+201B +0.08%) +10%
demo/browser/runtime.(hash).js
43.17KB (+103B +0.23%) +10%
demo/browser/main.(hash).js
295.02KB (+40B +0.01%) +10%
Unchanged files (2)
Status Path Size Limits
demo/browser/styles.(hash).css
16.27KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +348B +0.05%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.16MB (+20.42KB +0.28%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea waterplea marked this pull request as ready for review October 16, 2024 07:29
@waterplea waterplea merged commit 10198a1 into main Oct 17, 2024
25 of 26 checks passed
@waterplea waterplea deleted the sheet branch October 17, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Dialog update to the new spec
4 participants