Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): TuiInputPhoneInternational has separator customization #9601

Conversation

nezar-khamidekh
Copy link
Contributor

Closes #9518

@nezar-khamidekh nezar-khamidekh requested a review from a team as a code owner October 24, 2024 08:55
@nezar-khamidekh nezar-khamidekh requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 24, 2024 08:55
Copy link

lumberjack-bot bot commented Oct 24, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.20%. Comparing base (4a26b1a) to head (70d5b88).
Report is 531 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9601      +/-   ##
==========================================
- Coverage   75.68%   75.20%   -0.49%     
==========================================
  Files        1216     1242      +26     
  Lines       19068    19504     +436     
  Branches     2091     2122      +31     
==========================================
+ Hits        14432    14668     +236     
- Misses       4592     4789     +197     
- Partials       44       47       +3     
Flag Coverage Δ
summary 75.20% <ø> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Oct 24, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
297.7KB (+30B +0.01%) +10%
demo/browser/runtime.(hash).js
43.29KB (+22B +0.05%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
255.67KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +52B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.17MB (+5.32KB +0.07%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nezar-khamidekh nezar-khamidekh force-pushed the feat/input-phone-international-mask-separator branch from 24470b5 to 61c3197 Compare October 24, 2024 09:50
Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@nsbarsukov nsbarsukov changed the title feat(kit): added separator providing for TuiInputPhoneInternational feat(kit): TuiInputPhoneInternational has separator customization Oct 24, 2024
@nsbarsukov nsbarsukov added the community contribution This issue was closed by a PR from the community label Oct 24, 2024
@nezar-khamidekh nezar-khamidekh force-pushed the feat/input-phone-international-mask-separator branch from d377f97 to 3675976 Compare October 25, 2024 11:24
@nezar-khamidekh nezar-khamidekh force-pushed the feat/input-phone-international-mask-separator branch from 3675976 to 70d5b88 Compare October 25, 2024 12:18
@vladimirpotekhin vladimirpotekhin merged commit 7939bc5 into taiga-family:main Oct 25, 2024
24 checks passed
@nezar-khamidekh nezar-khamidekh deleted the feat/input-phone-international-mask-separator branch October 25, 2024 15:19
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community
Development

Successfully merging this pull request may close these issues.

🚀 - InputPhoneInternational mask separator customisation
3 participants