fix(button): fix button margin for right aligned icons #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterplea
approved these changes
Feb 1, 2021
|
Please use package name as scope in commit messages next time ;) |
fynnfeldpausch
added a commit
to mindsmash/taiga-ui
that referenced
this pull request
Feb 4, 2021
* main: (29 commits) feat(i18n): add Dutch with 100% support (taiga-family#206) chore(i18n): add Turkish to exports feat(i18n): add Turkish with 100% support (taiga-family#200) chore(demo): fix import sample chore(changelog): fix incorrect generated logs chore(release): 2.4.0 chore(docs): update styles on getting-started feat(core): add scss mixin support (taiga-family#165) chore(i18n): add german to exports feat(i18n): Add german localisation (taiga-family#198) fix(core): `Button` fix margin for right aligned icons (taiga-family#173) chore(demo): fix dark theme landing feat(i18n): add Spanish with 100% support (taiga-family#191) fix(button): fix button loader size for XL (taiga-family#174) feat(kit): use lazy loading strategy in avatar component (taiga-family#185) chore(demo): fix typo chore(demo): fix customization examples chore(changelog): fix incorrect generated logs chore(release): 2.3.0 fix(core): `Svg` properly use Angular `Sanitizer` (taiga-family#170) ... # Conflicts: # projects/core/components/button/button.style.less # projects/core/components/hints-host/hint-box/hint-box.style.less # projects/core/components/notification/notification.style.less # projects/core/components/primitive-checkbox/primitive-checkbox.style.less # projects/core/styles/theme/variables.less # projects/demo/src/modules/app/home/home.template.html # projects/kit/components/accordion/accordion-item/accordion-item.style.less # projects/kit/components/input-count/input-count.style.less # projects/kit/components/input-tag/input-tag.style.less # projects/kit/components/tag/tag.style.less
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Right aligned margins have wrong margin.
What is the new behavior?
Right aligned margins have correct margin.
Does this PR introduce a breaking change?
Other information