Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): InputMonth reopen calendar with year of the selected value #1773

Merged
merged 1 commit into from
May 17, 2022

Conversation

nsbarsukov
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes UIKIT-5805

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@lumberjack-bot
Copy link

lumberjack-bot bot commented May 17, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 9c7b1d8):

https://taiga-ui--pr1773-input-month-fix-c6cscbyk.web.app

(expires Wed, 18 May 2022 14:15:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1773 (9c7b1d8) into main (dbf83f7) will increase coverage by 0.03%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1773      +/-   ##
==========================================
+ Coverage   63.26%   63.29%   +0.03%     
==========================================
  Files         922      922              
  Lines       10014    10018       +4     
  Branches     1935     1937       +2     
==========================================
+ Hits         6335     6341       +6     
+ Misses       3229     3227       -2     
  Partials      450      450              
Flag Coverage Δ
addon-charts 74.42% <ø> (ø)
addon-doc 25.82% <ø> (ø)
addon-editor 45.87% <ø> (ø)
addon-mobile ∅ <ø> (∅)
addon-table 81.39% <ø> (ø)
addon-tablebars ∅ <ø> (∅)
cdk 69.63% <ø> (ø)
core 67.78% <ø> (ø)
kit 63.15% <87.50%> (+0.07%) ⬆️
summary 63.29% <87.50%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/calendar-month/calendar-month.component.ts 73.07% <80.00%> (+1.64%) ⬆️
...it/components/input-month/input-month.component.ts 62.06% <100.00%> (+8.22%) ⬆️
projects/cdk/utils/focus/set-native-focused.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbf83f7...9c7b1d8. Read the comment docs.

@waterplea waterplea merged commit e67fd15 into main May 17, 2022
@waterplea waterplea deleted the input-month-fix branch May 17, 2022 14:44
@well-done-bot
Copy link

well-done-bot bot commented May 17, 2022

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants