Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-table): Table disappearing borders #5999

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

Smedrix
Copy link
Contributor

@Smedrix Smedrix commented Nov 17, 2023

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Part of #5645

What is the new behaviour?

filter: opacity(1) doesn't work as expected in Safari, so we have to use transform: translate3d(0, 0, 0)

Copy link

lumberjack-bot bot commented Nov 17, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode changed the title fix(addon-table): `Table disappearing borders fix(addon-table): Table disappearing borders Nov 17, 2023
Copy link

bundlemon bot commented Nov 17, 2023

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
341.96KB +10%
demo/browser/vendor.(hash).js
200.75KB +10%
demo/browser/runtime.(hash).js
40.44KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
2.26MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ff58c7) 71.94% compared to head (87592fc) 71.94%.

❗ Current head 87592fc differs from pull request most recent head 1d64468. Consider uploading reports for the commit 1d64468 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5999   +/-   ##
=======================================
  Coverage   71.94%   71.94%           
=======================================
  Files        1462     1462           
  Lines       15973    15973           
  Branches     2265     2265           
=======================================
  Hits        11491    11491           
  Misses       4111     4111           
  Partials      371      371           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.62% <ø> (ø)
addon-mobile 60.58% <ø> (ø)
addon-table 60.75% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.65% <ø> (ø)
core 77.99% <ø> (ø)
kit 70.17% <ø> (ø)
summary 71.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit 6dcdb66 into taiga-family:main Nov 17, 2023
21 checks passed
AtharvChandratre pushed a commit to AtharvChandratre/taiga-ui that referenced this pull request Nov 19, 2023
AtharvChandratre pushed a commit to AtharvChandratre/taiga-ui that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants