Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): fix play/pause icons, add eur and gbp currency #77

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

alexfriesen
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other... Please describe:

What is the current behavior?

The documentation used "tuiIconPlay2Large" and "tuiIconPause2Large" as the play/pause icons, which do not exist.

Issue Number: N/A

What is the new behavior?

The correct icons will be used "tuiIconPlayLarge" and "tuiIconPauseLarge"

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I also added EUR and GBP to the currency Example

Copy link
Collaborator

@MarsiBarsi MarsiBarsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

Thank you for your PR! I will take a look at why there were some issues with CI later but I see that there are no potential problems :)

@MarsiBarsi MarsiBarsi merged commit 360a3b1 into taiga-family:main Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants