Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(layout): Navigation fix drawer positioning #9594

Merged
merged 4 commits into from
Oct 24, 2024
Merged

fix(layout): Navigation fix drawer positioning #9594

merged 4 commits into from
Oct 24, 2024

Conversation

waterplea
Copy link
Collaborator

Fixes #

@waterplea waterplea requested a review from a team as a code owner October 23, 2024 13:29
@waterplea waterplea requested review from MarsiBarsi, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 23, 2024 13:29
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 23, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit a8c7320):

https://taiga-previews--pr9594-navigation-nwzif2gp.web.app

(expires Thu, 24 Oct 2024 15:43:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 23, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 297.17KB +10%
✅ demo/browser/vendor.(hash).js
 255.67KB +10%
✅ demo/browser/runtime.(hash).js
 43.22KB +10%
✅ demo/browser/styles.(hash).css
 19.61KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +2B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.16MB (+45B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@waterplea waterplea merged commit d0560c8 into main Oct 24, 2024
27 checks passed
@waterplea waterplea deleted the navigation branch October 24, 2024 12:28
@taiga-family-bot taiga-family-bot mentioned this pull request Oct 28, 2024
Merged
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
@waterplea @taiga-family-bot @shiv9604
fix(layout): Navigation fix drawer positioning (taiga-family#9594)
6a60823 
Co-authored-by: taiga-family-bot <taiga-family-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@waterplea waterplea

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waterplea @nsbarsukov @vladimirpotekhin @taiga-family-bot