Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cdk): fix migration issues #9603

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

vladimirpotekhin
Copy link
Member

part of #8839

add comment for TUI_DIALOG_CLOSES_ON_BACK
fix decimal="never" migration
fix comment for *night variables

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner October 24, 2024 13:22
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team October 24, 2024 13:22
Copy link

lumberjack-bot bot commented Oct 24, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 53c2593):

https://taiga-previews--pr9603-fix-some-migr-issues-pfuk18ys.web.app

(expires Fri, 25 Oct 2024 13:27:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 24, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
297.56KB +10%
demo/browser/vendor.(hash).js
255.67KB +10%
demo/browser/runtime.(hash).js
43.26KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.17MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin merged commit 38b2568 into main Oct 28, 2024
27 of 28 checks passed
@vladimirpotekhin vladimirpotekhin deleted the fix-some-migr-issues branch October 28, 2024 09:22
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants