Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): new tuiProgressFixedGradient for ProgressBar #9648

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

afferenslucem
Copy link
Contributor

@afferenslucem afferenslucem commented Oct 31, 2024

Fixes #7088

@afferenslucem afferenslucem requested a review from a team as a code owner October 31, 2024 08:00
@afferenslucem afferenslucem requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 31, 2024 08:00
Copy link

lumberjack-bot bot commented Oct 31, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.19%. Comparing base (4a26b1a) to head (f64547b).
Report is 590 commits behind head on main.

Files with missing lines Patch % Lines
...ixed-gradient/progress-fixed-gradient.directive.ts 66.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9648      +/-   ##
==========================================
- Coverage   75.68%   75.19%   -0.50%     
==========================================
  Files        1216     1247      +31     
  Lines       19068    19573     +505     
  Branches     2091     2117      +26     
==========================================
+ Hits        14432    14718     +286     
- Misses       4592     4808     +216     
- Partials       44       47       +3     
Flag Coverage Δ
summary 75.19% <68.75%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Oct 31, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
298.9KB (+262B +0.09%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
259.74KB +10%
demo/browser/runtime.(hash).js
43.41KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +262B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.23MB (+380B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov changed the title feat: added fixed gradient progress feat(kit): new tuiProgressFixedGradient for ProgressBar Nov 1, 2024
Copy link
Member

@nsbarsukov nsbarsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribition!

  • Chrome Desktop ✅
  • Firefox Desktop ✅
  • Safari Desktop ✅
  • Safari IOS 18 ✅

@nsbarsukov nsbarsukov added the community contribution This issue was closed by a PR from the community label Nov 1, 2024
@waterplea waterplea merged commit ca81b5c into taiga-family:main Nov 5, 2024
25 of 26 checks passed
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
…aiga-family#9648)

Co-authored-by: Alexandr Shakirov <al.a.shakirov@tinkoff.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community
Development

Successfully merging this pull request may close these issues.

🚀 - New tuiProgressGradient for ProgressBar
4 participants