Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(layout): Navigation fix aside width according to spec #9815

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix(layout): Navigation fix aside width according to spec #9815

merged 2 commits into from
Nov 26, 2024

Conversation

vladimirpotekhin
Copy link
Member

Fixes #

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner November 22, 2024 13:38
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team November 22, 2024 13:38
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 22, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit c2ee5a2):

https://taiga-previews-demo--pr9815-fix-nav-width-demo-0vm06bcf.web.app

(expires Wed, 27 Nov 2024 06:59:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 22, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 304.37KB +10%
✅ demo/browser/vendor.(hash).js
 260.11KB +10%
✅ demo/browser/runtime.(hash).js
 44.03KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change -1B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.34MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited
Loading

Playwright test results

failed  2 failed
passed  971 passed

Details

report  Open report ↗︎
stats  973 tests across 69 suites
duration  10 minutes, 1 second
commit  c2ee5a2

Failed tests

chromium › tests/demo/demo.pw.spec.ts › Demo › /components/navigation
chromium › tests/layout/navigation.pw.spec.ts › Navigation › A12y

@nsbarsukov nsbarsukov self-requested a review November 25, 2024 10:42
@vladimirpotekhin vladimirpotekhin merged commit b92202e into main Nov 26, 2024
24 of 25 checks passed
@vladimirpotekhin vladimirpotekhin deleted the fix-nav-width branch November 26, 2024 07:32
@taiga-family-bot taiga-family-bot mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsbarsukov nsbarsukov nsbarsukov approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@vladimirpotekhin vladimirpotekhin

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladimirpotekhin @splincode @nsbarsukov