-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions regarding the computation of the path lenght #11
Comments
Hi Reuben, |
Thanks Reuben, |
Hi Guotai,
I have few questions regarding the way you use the spacial information in your code:
GeodisTK/cpp/geodesic_distance_3d.cpp
Line 287 in 7907b38
I am not sure that this factor is correct, I think that the factor should be proportional to
1/local_dis_b[i]
.Let's be given an image I with a spacing [a, b, c] and a point S used as seed. S is located at [x,y,z] in the voxel space and at S=O + [xa, yb, z*c] where O is the origin in the scanner space.
Let's consider that we want to know the length of the straight path between S and the voxel just above in the z axis, i.e. T = O + [xa, yb, (z+1)*c].
Then, I would say that the length of the path is:

where the unit vector u = Γ ′(s)/||Γ ′(s)|| is tangent to the direction of the path.
If you agree with that, that would also change the way the normalisation is performed for the other path direction.


For example if the curve has a direction (1,1,1), this would lead to a factor
instead of:
Please let me know what you think.
Thank you!
Regards,
Reuben
The text was updated successfully, but these errors were encountered: