You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cargo-hack supports cargo 1.26+, so our test crates usually don't set the edition. (edition field requires 1.31+)
However, the new cargo warning for the unset edition (rust-lang/cargo#13505, I think the warning itself is a good idea, except for a few small problems) pollutes the logs, and it confuses assertions.
I think a reasonable workaround is to check while excluding warnings. The potentially difficult part is that in some cases we want to check the content of warnings as well.
Ideally, I would like to see cargo provide a way to opt out of this warning, but I don't think that is realistic as I think cargo has never provided such a way in the past.
I think a reasonable workaround is to check while excluding warnings. The potentially difficult part is that in some cases we want to check the content of warnings as well.
This could probably be handled well if implemented to always ignore only warnings containing specific patterns ("no edition set: defaulting to the 2015 edition" in this case).
cargo-hack supports cargo 1.26+, so our test crates usually don't set the edition. (edition field requires 1.31+)
However, the new cargo warning for the unset edition (rust-lang/cargo#13505, I think the warning itself is a good idea, except for a few small problems) pollutes the logs, and it confuses assertions.
I think a reasonable workaround is to check while excluding warnings. The potentially difficult part is that in some cases we want to check the content of warnings as well.
Ideally, I would like to see cargo provide a way to opt out of this warning, but I don't think that is realistic as I think cargo has never provided such a way in the past.
The text was updated successfully, but these errors were encountered: