Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] v0.6.27 runs all-features before powerset but ignores mutually-exclusive-features #250

Closed
e1732a364fed opened this issue Apr 14, 2024 · 3 comments
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-bug Category: related to a bug.

Comments

@e1732a364fed
Copy link

Problem:
It seems that some new code in 0.6.27 runs all-features before powerset, but it ignores mutually-exclusive-features

Proof:

See the github action log in my project:

0.6.27: break
https://github.com/e1732a364fed/ruci/actions/runs/8679836216/job/23799420486

restrict cargo hack version to 0.6.26: test ok
https://github.com/e1732a364fed/ruci/actions/runs/8679872586/job/23799558747

In my project I used mlua, it provides both "luau" and "lua54" features, but only one can be enabled.

@e1732a364fed e1732a364fed changed the title [bug] v0.6.27 runs all-features without mutually-exclusive-features [bug] v0.6.27 runs all-features before powerset but ignores mutually-exclusive-features Apr 14, 2024
@e1732a364fed
Copy link
Author

e1732a364fed commented Apr 14, 2024

I think it's related to :
#247

Also I think it is a bug, rather than something that user have to bypass by using other flags.

@taiki-e taiki-e added C-bug Category: related to a bug. A-features Area: features (--feature-powerset, --each-feature, etc.) labels Apr 17, 2024
@taiki-e
Copy link
Owner

taiki-e commented Apr 17, 2024

Thanks for the report. The relevant logic was always wrong since the implementation of mutually-exclusive-features, but before #247 it was not easy to trigger.

@taiki-e
Copy link
Owner

taiki-e commented Apr 17, 2024

Fixed in 0.6.28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-bug Category: related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants