Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for --skip is incorrect #45

Closed
Nemo157 opened this issue Jun 20, 2020 · 1 comment · Fixed by #46
Closed

Documentation for --skip is incorrect #45

Nemo157 opened this issue Jun 20, 2020 · 1 comment · Fixed by #46
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-bug Category: related to a bug.

Comments

@Nemo157
Copy link

Nemo157 commented Jun 20, 2020

The documentation claims that it takes a "Space-separated list of features to skip", but it actually appears to want a comma-separated list:

> cargo hack --skip 'all all-implementations all-algorithms' --feature-powerset check
[...]
info: running `cargo check --no-default-features --features all,all-implementations,deflate,futures-bufread` on async-compression (31/4097)
[...]
> cargo hack --skip 'all,all-implementations,all-algorithms' --feature-powerset check
[...]
info: running `cargo check --no-default-features --features deflate,futures-write,lzma` on async-compression (23/513)
[...]
@taiki-e taiki-e added C-documentation Category: related to documentation. C-bug Category: related to a bug. labels Jun 20, 2020
@bors bors bot closed this as completed in 0c73e22 Jun 20, 2020
@bors bors bot closed this as completed in #46 Jun 20, 2020
@taiki-e
Copy link
Owner

taiki-e commented Jun 20, 2020

Published 0.3.10 which fixes this issue (space-separated list should now be handled correctly), thanks for the reporting!

@taiki-e taiki-e added A-features Area: features (--feature-powerset, --each-feature, etc.) and removed C-documentation Category: related to documentation. labels Dec 18, 2020
@taiki-e taiki-e added the A-cli label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-bug Category: related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants