Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intelligently feature combination exclusion (#85) does not work properly when used with --group-features #97

Closed
taiki-e opened this issue Dec 1, 2020 · 1 comment · Fixed by #99
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-bug Category: related to a bug.

Comments

@taiki-e
Copy link
Owner

taiki-e commented Dec 1, 2020

#81 (comment)

@taiki-e taiki-e added A-features Area: features (--feature-powerset, --each-feature, etc.) C-bug Category: related to a bug. labels Dec 1, 2020
@taiki-e
Copy link
Owner Author

taiki-e commented Dec 1, 2020

This is due to intelligently feature combination exclusion does not check whether the features are separated by "," or "/". --include-deps-features has a similar problem.

let s = g.join(",");

features.extend(dep_package.features.keys().map(|f| format!("{}/{}", name, f)));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-bug Category: related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant