Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: Add a --skip subcommand #24

Closed
kleimkuhler opened this issue Dec 20, 2019 · 1 comment · Fixed by #25
Closed

request: Add a --skip subcommand #24

kleimkuhler opened this issue Dec 20, 2019 · 1 comment · Fixed by #25
Assignees
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-enhancement Category: A new feature or an improvement for an existing one

Comments

@kleimkuhler
Copy link
Contributor

Motivation

--feature-powerset was added recently and it has been really helpful.
Unfortunately, if there is a feature that doesn't need to be tested in the
combinations it's not possible to skip. Each additional feature that is tested
in the powerset doubles the run-time so it can be costly as the number of
features grows.

Solution

Add a --skip subcommand that can be paired with --each-feature or
--feature-powerset. The latter subcommands would filter out any features
passed in --skip before running their own logic.

I wanted to open the issue before sending in a PR incase @taiki-e had any
thoughts? If this is something you are okay with adding, I can send in a quick
change to add it. It should be fairly straightforward.

@taiki-e
Copy link
Owner

taiki-e commented Dec 23, 2019

Seems reasonable to me!

@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Dec 23, 2019
bors bot added a commit that referenced this issue Jan 5, 2020
25: Add skip command r=taiki-e a=kleimkuhler

Closes #24 

Signed-off-by: Kevin Leimkuhler <kleimkuhler@icloud.com>


Co-authored-by: Kevin Leimkuhler <kleimkuhler@icloud.com>
@bors bors bot closed this as completed in ab71171 Jan 5, 2020
@bors bors bot closed this as completed in #25 Jan 5, 2020
@taiki-e taiki-e added the A-features Area: features (--feature-powerset, --each-feature, etc.) label Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-enhancement Category: A new feature or an improvement for an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants