Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected behaviour in the coverage of the lines of the test functions #243

Closed
caemor opened this issue Feb 22, 2023 · 2 comments
Closed

Unexpected behaviour in the coverage of the lines of the test functions #243

caemor opened this issue Feb 22, 2023 · 2 comments
Labels
C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream)

Comments

@caemor
Copy link

caemor commented Feb 22, 2023

While checking a crate for its test coverage I saw that custom panic messages in test functions are counted as uncovered lines. Is this expected behavior and is already a way to fix this?

Below is a screenshot of a simplified example:

image
@taiki-e
Copy link
Owner

taiki-e commented Feb 22, 2023

This means that some of the code generated by the assert_eq macro is not covered, but I believe this is an upstream bug anyway. (It is somewhat similar to rust-lang/rust#98712.)

Would you mind submitting an issue at https://github.com/rust-lang/rust?

@taiki-e taiki-e added the C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream) label Feb 22, 2023
@Phoenix500526 Phoenix500526 mentioned this issue Jun 21, 2023
Closed
@taiki-e taiki-e mentioned this issue May 2, 2024
Closed
@taiki-e
Copy link
Owner

taiki-e commented May 2, 2024

Closing in favor of upstream bug report (rust-lang/rust#84892).

@taiki-e taiki-e closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caemor @taiki-e