Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why was 1.0.10 yanked from crates.io? #348

Closed
dsherret opened this issue Jul 5, 2022 · 6 comments
Closed

Why was 1.0.10 yanked from crates.io? #348

dsherret opened this issue Jul 5, 2022 · 6 comments
Labels
C-question Category: A question

Comments

@dsherret
Copy link

dsherret commented Jul 5, 2022

I'm just curious why 1.0.10 was yanked from crates.io? I guess old binary crates depending on a pinned old version of pin-project will no longer build?

image

@dsherret dsherret changed the title Why was 1.0.10 yanked from cargo? Why was 1.0.10 yanked from crates.io? Jul 5, 2022
@taiki-e
Copy link
Owner

taiki-e commented Jul 5, 2022

After recent compiler changes, rustc almost always emits dead code warnings for the code generated by pin-project (#346).
It broke the minimal versions check of some projects, so, I have yanked old versions.

@taiki-e
Copy link
Owner

taiki-e commented Jul 5, 2022

I guess old binary crates depending on a pinned old version of pin-project will no longer build?

No, if Cargo.lock exists it builds with a warning.

@dsherret
Copy link
Author

dsherret commented Jul 5, 2022

I guess old binary crates depending on a pinned old version of pin-project will no longer build?

No, if Cargo.lock exists it builds with a warning.

> cargo install deno --version 1.23.0
  Downloaded deno v1.23.0
  Downloaded 1 crate (3.3 MB) in 2.69s
    Updating crates.io index
  Installing deno v1.23.0
error: failed to compile `deno v1.23.0`, intermediate artifacts can be found at `C:\Users\david\AppData\Local\Temp\cargo-installSzOTgk`

Caused by:
  failed to select a version for the requirement `pin-project = "=1.0.10"`
  candidate versions found which didn't match: 1.0.11, 0.4.30, 0.3.5, ...
  location searched: crates.io index
  required by package `deno v1.23.0`

It seems to have broken them.

@taiki-e
Copy link
Owner

taiki-e commented Jul 5, 2022

Can you use --locked flag?

@dsherret
Copy link
Author

dsherret commented Jul 5, 2022

Yup, it works with --locked. That's not too bad then. I documented it. Thanks!

@dsherret dsherret closed this as completed Jul 5, 2022
@taiki-e
Copy link
Owner

taiki-e commented Jul 5, 2022

The reason it was yanked is for pedantic checks in some projects (i.e., low importance), so I reverted the yank for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-question Category: A question
Projects
None yet
Development

No branches or pull requests

2 participants