Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(host): create initial cancel handling #316

Merged
merged 46 commits into from
Jul 22, 2024
Merged

feat(host): create initial cancel handling #316

merged 46 commits into from
Jul 22, 2024

Conversation

petarvujovic98
Copy link
Contributor

No description provided.

@smtmfft smtmfft mentioned this pull request Jul 17, 2024
Open
26 tasks
@petarvujovic98 petarvujovic98 enabled auto-merge July 17, 2024 10:02
@petarvujovic98 petarvujovic98 added this to the ZK proofs on mainnet milestone Jul 17, 2024
@petarvujovic98
feat(risc0): add cancellation to bonsai (#320)
1279c0a 
* feat(risc0): add cancellation to bonsai

* fix(risc0): remove id after cancellation

* fix(risc0): add prover code to proof key
@petarvujovic98
feat(sp1): add cancellation support (#322)
c767327 
* feat(sp1): add cancellation support

* fix(sp1): add prover code to proof key
smtmfft
smtmfft approved these changes Jul 22, 2024
View reviewed changes
core/src/preflight.rs Show resolved Hide resolved
host/src/server/api/mod.rs Show resolved Hide resolved
provers/risc0/driver/src/lib.rs Show resolved Hide resolved
lib/src/prover.rs Show resolved Hide resolved
tasks/src/lib.rs Show resolved Hide resolved
@smtmfft
Copy link
Contributor

smtmfft commented Jul 22, 2024

One more thing: for proof request, I think we probably need a force tag in v2 to force re-produce the proof & overwrite the error status (if success).

@petarvujovic98 petarvujovic98 added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit f6d02b3 Jul 22, 2024
17 checks passed
@petarvujovic98 petarvujovic98 deleted the cancel-api branch July 22, 2024 09:31
@petarvujovic98
Copy link
Contributor Author

petarvujovic98 commented Jul 22, 2024 •
edited
Loading

One more thing: for proof request, I think we probably need a force tag in v2 to force re-produce the proof & overwrite the error status (if success).

@smtmfft The current intended way to do this would be to just cancel the current task (even if it is successful or errored out) and prove it again.

@taiko-kitty taiko-kitty mentioned this pull request Jul 19, 2024
Merged
@smtmfft
Copy link
Contributor

smtmfft commented Jul 22, 2024

The current intended way to do this would be to just cancel the current task (even if it is successful or errored out) and prove it again.

oh, maybe I misunderstand the logic, I thought it will report "cancelled" state if same (cancelled) task comes again.

@petarvujovic98
Copy link
Contributor Author

We could change the behavior if needed, this is the current way it is handled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smtmfft smtmfft smtmfft approved these changes

@Champii Champii Awaiting requested review from Champii

Assignees

@petarvujovic98 petarvujovic98

Labels
None yet
Projects
None yet
Milestone
ZK proofs on mainnet
Development

Successfully merging this pull request may close these issues.
2 participants
@petarvujovic98 @smtmfft