Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): multiple improvements & bug fixes #15255

Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Nov 25, 2023

  • Improve bridged token name and symbol override
  • Update eventindexer post hooks
  • Fix a bug in ERC20Vault
  • Make governor upgradable
  • Use RC1967Proxy instead of TransparentUpgradeableProxy
  • Split the original EssentialContract into an OwnerUUPSUpgradable.sol and a new EssentialContract
  • Removed all ProxiedXXXContract as all owner contracts must be used behind a proxy. This is enforced by calling _disableInitializers in constructor.
  • Simplified test imports to make it more readable.
  • Add airdrop contracts
  • Improve and test guardian prove
  • Allow changing Bridged ERC20 token on dest chain

Co-authored-by: ptchela <80599907+ptchela@users.noreply.github.com>
Co-authored-by: Daniel Wang <dong77@gmail.com>
Copy link

vercel bot commented Nov 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a5 ✅ Ready (Inspect) Visit Preview Dec 2, 2023 3:01pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
bridge-ui-v2-internal ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2023 3:01pm

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 370 lines in your changes are missing coverage. Please review.

Comparison is base (42fee21) 27.97% compared to head (729e155) 27.42%.

Files Patch % Lines
packages/eventindexer/generator/generator.go 0.00% 138 Missing ⚠️
.../eventindexer/indexer/save_block_assigned_event.go 0.00% 103 Missing ⚠️
packages/eventindexer/indexer/subscribe.go 0.00% 77 Missing ⚠️
packages/eventindexer/repo/stat.go 47.72% 21 Missing and 2 partials ⚠️
packages/eventindexer/indexer/filter.go 0.00% 11 Missing ⚠️
packages/eventindexer/indexer/indexer.go 0.00% 9 Missing ⚠️
packages/eventindexer/http/get_chart_by_task.go 0.00% 3 Missing ⚠️
packages/eventindexer/repo/event.go 0.00% 2 Missing and 1 partial ⚠️
...entindexer/indexer/save_transition_proved_event.go 0.00% 2 Missing ⚠️
packages/eventindexer/http/get_stats.go 94.73% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           based_contestable_zkrollup   #15255      +/-   ##
==============================================================
- Coverage                       27.97%   27.42%   -0.56%     
==============================================================
  Files                              76       77       +1     
  Lines                            4740     4923     +183     
==============================================================
+ Hits                             1326     1350      +24     
- Misses                           3267     3426     +159     
  Partials                          147      147              
Flag Coverage Δ
eventindexer 18.37% <9.97%> (-0.36%) ⬇️
relayer 39.98% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Daniel Wang <dong77@gmail.com>
Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com>
Co-authored-by: David <david@taiko.xyz>
Co-authored-by: D <51912515+adaki2004@users.noreply.github.com>
Co-authored-by: Daniel Wang <dong77@gmail.com>
Co-authored-by: jeff <113397187+cyberhorsey@users.noreply.github.com>
Co-authored-by: David <david@taiko.xyz>
…ipt (#15310)

Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com>
@dantaik dantaik merged commit 337c57c into based_contestable_zkrollup Dec 2, 2023
12 checks passed
@dantaik dantaik deleted the based_contestable_zkrollup_improved branch December 2, 2023 21:11
@dantaik dantaik restored the based_contestable_zkrollup_improved branch December 3, 2023 10:54
@dantaik dantaik deleted the based_contestable_zkrollup_improved branch December 3, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants