Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui-v2): configuredCustomTokens in file/document is inconsistency #15335

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

conanxyz
Copy link

@conanxyz conanxyz commented Dec 5, 2023

I attempted to deploy the bridge frontend based on the documentation and noticed a discrepancy between the configuredCustomToken and the file name.

cp config/sample/configuredCustomTokens.example config/configuredCustomTokens.json

The README document here uses 'configuredCustomTokens.example,' while in the actual 'config' directory, it is 'configuredCustomToken.example.' I believe it should be changed to 'configuredCustomTokens.example,' and the references in the code should be updated also

Copy link

vercel bot commented Dec 5, 2023

Someone is attempting to deploy a commit to the taikoxyz Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@KorbinianK KorbinianK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@KorbinianK KorbinianK enabled auto-merge December 5, 2023 13:31
@KorbinianK KorbinianK added this pull request to the merge queue Dec 5, 2023
Merged via the queue into taikoxyz:main with commit 92db840 Dec 5, 2023
4 checks passed
Copy link

gitpoap-bot bot commented Dec 5, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Taiko Contributor:

GitPOAP: 2023 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot mentioned this pull request Dec 5, 2023
mintcnn pushed a commit to mintcnn/taiko-mono that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants