fix(protocol): replace __self in bytecode for all EssentialContracts when generating genesis JSON
#15476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t`s when generating genesis JSON
…t`s when generating genesis JSON
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…t`s when generating genesis JSON
…t`s when generating genesis JSON
davidtaikocha
requested review from
Brechtpd,
adaki2004,
dantaik and
cyberhorsey
adaki2004
approved these changes
Jan 10, 2024
dantaik
approved these changes
Jan 10, 2024
Brechtpd
reviewed
Jan 10, 2024
| contractArtifacts.BridgedERC20Impl, | ||
| uupsImmutableReferencesMap, | ||
| ethers.utils.hexZeroPad(addressMap.BridgedERC20Impl, 32), | ||
| ).deployedBytecode.object, | ||
| }, | ||
| BridgedERC721: { |
There was a problem hiding this comment.
I see BridgedERC1155 and BridgedERC20 getting patched, but not BridgedERC721. Shouldn't it also be patched?
There was a problem hiding this comment.
Plz review: #15479
This was referenced Feb 9, 2024
Closed
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed the broken proxy upgrade test in
GenerateGenesis.g.sol