Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(protocol)!: enforce naming convention #16168

Merged
merged 91 commits into from
Feb 29, 2024
Merged

chore(protocol)!: enforce naming convention #16168

merged 91 commits into from
Feb 29, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 28, 2024 •
edited
Loading

Enforce style guide stated in "CONTRIBU".

@dantaik dantaik marked this pull request as ready for review February 28, 2024 13:29
@dantaik dantaik mentioned this pull request Feb 28, 2024
Closed
@dantaik dantaik requested review from KorbinianK and cyberhorsey and removed request for dionysuzx February 28, 2024 13:33
@dantaik dantaik changed the base branch from main to fix_foundry February 28, 2024 13:40
Base automatically changed from fix_foundry to main February 28, 2024 14:07
@dionysuzx
Copy link
Collaborator

dionysuzx commented Feb 29, 2024 •
edited
Loading

@dantaik where is "contracts/SOLIDITY_STYLE_GUIDE.md"? i don't see it. nevermind

@dantaik dantaik changed the base branch from internal to oz/missing-docstrings February 29, 2024 09:11
Base automatically changed from oz/missing-docstrings to main February 29, 2024 09:24
@dantaik dantaik marked this pull request as ready for review February 29, 2024 09:57
@dantaik dantaik added this pull request to the merge queue Feb 29, 2024
@dantaik dantaik removed this pull request from the merge queue due to a manual request Feb 29, 2024
@dantaik dantaik added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 1f6a8af Feb 29, 2024
7 checks passed
@dantaik dantaik deleted the naming_conv branch February 29, 2024 10:14
This was referenced Feb 29, 2024
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

@KorbinianK KorbinianK Awaiting requested review from KorbinianK

@cyberhorsey cyberhorsey Awaiting requested review from cyberhorsey

Assignees

@dionysuzx dionysuzx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dantaik @dionysuzx @Brechtpd @adaki2004 @davidtaikocha