Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): trigger simultaneous recurring TKO snapshots #16715

Merged
merged 53 commits into from
Apr 18, 2024
Merged

feat(protocol): trigger simultaneous recurring TKO snapshots #16715

merged 53 commits into from
Apr 18, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 11, 2024 •
edited
Loading

To allow voting on both L1 and L2, we need to prevent the same token from voting twice on both L1 and L2. Making sure snapshots of TKO are taken in the same time is one of the conditions to prevent double voting.

@dantaik dantaik marked this pull request as ready for review April 11, 2024 16:58
@dantaik dantaik requested review from Brechtpd and adaki2004 April 11, 2024 16:58
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 11, 2024 •
edited
Loading

feat(protocol): trigger simultaneous recurring TKO snapshots

Generated at commit: 343035e84f6709441e0cc7b6fa613c25ffb53d8b

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
4
40
48
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
guardian-dashboard-hekla ✅ Ready (Inspect) Visit Preview Apr 18, 2024 9:27am

@dantaik dantaik changed the title feat(protocol): force L1 and L2 to take TKO snapshot at the same time to avoid double voting feat(protocol): force L1 and L2 to take TKO snapshot at the same time to avoid double voting [do not merge] Apr 12, 2024
@dantaik dantaik changed the title feat(protocol): force L1 and L2 to take TKO snapshot at the same time to avoid double voting [do not merge] feat(protocol): trigger TKO snapshot regularly for both L1/L2 to avoid double voting [do not merge] Apr 12, 2024
@dantaik
Revert "more"
5372314 
This reverts commit 0512cb3.
@dantaik dantaik requested a review from davidtaikocha April 12, 2024 06:23
@dantaik dantaik changed the title feat(protocol): trigger TKO snapshot regularly for both L1/L2 to avoid double voting [do not merge] feat(protocol): trigger weekly TKO snapshot to avoid double voting Apr 12, 2024
@dantaik dantaik removed the request for review from davidtaikocha April 17, 2024 06:01
@dantaik dantaik disabled auto-merge April 17, 2024 06:01
@dantaik dantaik enabled auto-merge April 17, 2024 06:01
@dantaik dantaik requested a review from davidtaikocha April 17, 2024 06:01
@dantaik dantaik requested a review from adaki2004 April 18, 2024 05:00
@dantaik dantaik requested a review from adaki2004 April 18, 2024 08:14
@dantaik dantaik merged commit bffc8dc into main Apr 18, 2024
8 checks passed
@dantaik dantaik deleted the synced_snapshot branch April 18, 2024 12:51
@taiko-kitty taiko-kitty mentioned this pull request Apr 18, 2024
Merged
dantaik added a commit that referenced this pull request Apr 22, 2024
@dantaik
Revert "feat(protocol): trigger simultaneous recurring TKO snapshots (#…
acb38d4 
…16715)"

This reverts commit bffc8dc.
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brechtpd Brechtpd Brechtpd approved these changes

@davidtaikocha davidtaikocha Awaiting requested review from davidtaikocha

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @Brechtpd @adaki2004 @davidtaikocha