Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): remove ERC20SnapshotUpgradeable from TaikoToken and BrigedERC20 tokens #16809

Merged
merged 8 commits into from
Apr 23, 2024
Merged

feat(protocol): remove ERC20SnapshotUpgradeable from TaikoToken and BrigedERC20 tokens #16809

merged 8 commits into from
Apr 23, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 23, 2024 •
edited
Loading

ERC20SnapshotUpgradeable is not used at all and was inherited by Taiko Token and BridgedERC20 with an incorrect assumption. ERC20SnapshotUpgradeable has extra gas overhead so it's better to remove it from the inheritance.

@dantaik dantaik requested review from adaki2004 and Brechtpd April 23, 2024 03:18
@dantaik dantaik marked this pull request as ready for review April 23, 2024 03:18
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Apr 23, 2024 •
edited
Loading

feat(protocol): remove ERC20SnapshotUpgradeable from TaikoToken and BrigedERC20 tokens

Generated at commit: 389d6fb4586ab148f306ae6e15622ce90b16bc13

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
5
39
48
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title refactor(protocol): remove ERC20SnapshotUpgradeable from TaikoToken and BrigedERC20 tokens feat(protocol): remove ERC20SnapshotUpgradeable from TaikoToken and BrigedERC20 tokens Apr 23, 2024
@dantaik dantaik requested a review from adaki2004 April 23, 2024 07:34
@dantaik dantaik added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit f20a02f Apr 23, 2024
7 checks passed
@dantaik dantaik deleted the improve_taiko_token branch April 23, 2024 09:58
This was referenced Apr 23, 2024
Merged
Closed
@taiko-kitty taiko-kitty mentioned this pull request May 11, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @Brechtpd @adaki2004 @davidtaikocha