Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nfts): upgrade kbw contract to v2 #17967

Merged
merged 45 commits into from
Aug 30, 2024
Merged

feat(nfts): upgrade kbw contract to v2 #17967

merged 45 commits into from
Aug 30, 2024

Conversation

bearni95
Copy link
Contributor

Enable support for Golden Winner, the first of the winners array

bearni95 and others added 30 commits July 17, 2024 14:30
@bearni95
contract and basic tests
70c03b3
@bearni95
fixed comment typo
06b0607
@bearni95
linted and formatted
287c4f1
@bearni95
deployment scripts
6d6a6b7
@bearni95
cleanup
e1aa36d
@bearni95
reverted changes to taikoon data
68fedc1
@bearni95
change revert cleanup
fed511c
@bearni95
Merge branch 'main' into kbw-contracts-setup
cbfe8ee
@bearni95 @2manslkh
Update packages/nfts/contracts/party-ticket/TaikoPartyTicket.sol
1e101bb 
Co-authored-by: Kenk <kenghin_lim@hotmail.com>
@bearni95
removal of tokenId from tokenURI logic, beyond determining the winner
5d92631
@bearni95
Merge branch 'main' into kbw-contracts-setup
ba7845a
@bearni95
added mintWinner method
61f729e
@bearni95
Merge branch 'main' into kbw-contracts-setup
96d7309
@bearni95
Deployment updates for taiko-party-ticket
3e4f009
@bearni95
Merge branch 'kbw-contracts-setup' of ssh://github.com/taikoxyz/taiko…
5dc4952 
…-mono into kbw-contracts-setup
@bearni95
modifications for single-dir ipfs data root
bfaa57f
@bearni95
proper values for ipfs hekla testing
00d48a2
@bearni95
dev push
4e78bc4
@bearni95
uncommented dev lines
7f47c85
@bearni95
proper hekla deployment
a3aef0e
@bearni95
reverted error changes
7d057a9
@bearni95
patched up tests
6f6f51d
@bearni95
gap allocation fix; blacklist modifier
d7049cf
@bearni95
added revokeWinners method
3dcf0e2
@bearni95
modified code and added tests for upgradeability
5f7f4c1
@bearni95
Merge branch 'main' into kbw-contracts-setup
7d405f2
@bearni95
upgrade test confirmations
1ee33de
@bearni95
Merge branch 'kbw-contracts-setup' of ssh://github.com/taikoxyz/taiko…
997174e 
…-mono into kbw-contracts-setup
@bearni95
a typo...
c535e82
@bearni95
uncommented blacklist modifier
1ceacc3
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Aug 22, 2024 •
edited
Loading

feat(nfts): upgrade kbw contract to v2

Generated at commit: 55149905b49b2901af72ed8df3675168564a4163

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 20575b0 Aug 30, 2024
6 checks passed
@dantaik dantaik deleted the taiko-party-ticket-v2 branch August 30, 2024 03:01
@taiko-kitty taiko-kitty mentioned this pull request Aug 30, 2024
Closed
This was referenced Nov 4, 2024
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantaik dantaik dantaik approved these changes

@bennettyong bennettyong bennettyong approved these changes

@2manslkh 2manslkh Awaiting requested review from 2manslkh

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bearni95 @bennettyong @dantaik @davidtaikocha