Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): allow msg.sender to customize block proposer addresses #18048

Merged
merged 3 commits into from
Sep 9, 2024
Merged

feat(protocol): allow msg.sender to customize block proposer addresses #18048

merged 3 commits into from
Sep 9, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Sep 9, 2024 •
edited
Loading

This is necessary for PreconfTaskManager to assign the actual preconfers as the block proposers, not using the PreconfTaskManager contract itself.

@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
taiko-mono ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 7:20am

@dantaik dantaik marked this pull request as ready for review September 9, 2024 07:15
@dantaik dantaik changed the title feat(protocl): allow custom proposer to further customize the proposer address feat(protocol): allow custom proposer to further customize the proposer address Sep 9, 2024
@dantaik dantaik changed the title feat(protocol): allow custom proposer to further customize the proposer address feat(protocol): allow permissioned proposer to further customize block proposer addresses Sep 9, 2024
@dantaik dantaik enabled auto-merge September 9, 2024 07:24
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Sep 9, 2024 •
edited
Loading

feat(protocol): allow custom proposer to further customize the proposer address

Generated at commit: 3e8ff1fdf2f84dd8e69892d4744b5e9fcdeaad4f

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
43
55
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title feat(protocol): allow permissioned proposer to further customize block proposer addresses feat(protocol): allow msg.sender to customize block proposer addresses Sep 9, 2024
@dantaik dantaik requested a review from YoGhurt111 September 9, 2024 07:48
@dantaik dantaik added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 22055cc Sep 9, 2024
11 checks passed
@dantaik dantaik deleted the allow_custom_proposer branch September 9, 2024 08:00
This was referenced Sep 9, 2024
Closed
Merged
Merged
@YoGhurt111 YoGhurt111 mentioned this pull request Sep 9, 2024
Merged
@taiko-kitty taiko-kitty mentioned this pull request Nov 1, 2024
Closed
This was referenced Dec 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@YoGhurt111 YoGhurt111 YoGhurt111 approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dantaik @YoGhurt111 @davidtaikocha