fix(protocol): avoid invocation in Bridge message processing if calldata is "" and value is 0 #18137
+407
−405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
requested review from
KorbinianK,
Brechtpd,
adaki2004 and
davidtaikocha
dantaik
changed the title
dantaik
changed the title
fix(protocol): avoid invocation in Bridge message processing if calldata is "" and value is 0
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Brechtpd
reviewed
Sep 18, 2024
dantaik
changed the title
Brechtpd
approved these changes
Sep 18, 2024
adaki2004
approved these changes
Sep 18, 2024
dantaik
added a commit
that referenced
this pull request
Sep 18, 2024
…ata is "" and value is 0 (#18137)
This was referenced Nov 1, 2024
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing this transaction, we noticed that the processMessage transaction succeeded, but the internal message invocation failed due to an out-of-gas error. This failure occurred because the inner invocation was assigned a gas limit of 1 (since 0 is invalid), despite the invocation being unnecessary.
This PR introduces a check to skip the internal message invocation if the calldata is empty (""), preventing unnecessary execution and gas consumption, and also mark such transactions as "succeeded" instead of "retryable".