Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): make sure init() covers logics in init2(), init3().. #18292

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Oct 24, 2024

In our code init() is always called when a contract is deployed, not init2() init3(),...
With the modification in this PR, we make sure init() always covers the code in init2() andinit3(),...

@dantaik dantaik marked this pull request as ready for review October 24, 2024 07:04
Copy link

openzeppelin-code bot commented Oct 24, 2024

feat(protocol): make sure init() covers logics in init2(), init3()..

Generated at commit: 5c5626654fad49cbdb8143428fcb2468aa542a30

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
7
43
56
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title chore(protocol): make sure init() covers logics in init2, init3.. feat(protocol): make sure init() covers logics in init2(), init3().. Oct 24, 2024
@dantaik dantaik requested a review from YoGhurt111 October 25, 2024 02:16
@dantaik dantaik added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 9d06958 Oct 25, 2024
5 of 6 checks passed
@dantaik dantaik deleted the impv_AddressManager branch October 25, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants