-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(protocol): change Hekla sharingPctg to 80% & gasIssuancePerSecond to 1000000 #18322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1565b0c.
Its supported. |
davidtaikocha
approved these changes
Oct 28, 2024
YoGhurt111
approved these changes
Oct 28, 2024
dantaik
commented
Oct 28, 2024
chore(protocol): change Hekla base sharingPctg to 80%
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dantaik
commented
Oct 28, 2024
dantaik
changed the title
chore(protocol): change Hekla base sharingPctg to 80%
chore(protocol): change Hekla sharingPctg to 80% & gasIssuancePerSecond to 1000000
Oct 28, 2024
YoGhurt111
approved these changes
Oct 28, 2024
This was referenced Oct 28, 2024
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidtaikocha when we release 1.10.0, we can test that the fee sharing pctg will be 80%. Do you think taiko-geth already support this?
Maybe we should also change gasIssuancePerSecond to a much smaller value for Hekla?