Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol): change Hekla sharingPctg to 80% & gasIssuancePerSecond to 1000000 #18322

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Oct 28, 2024

@davidtaikocha when we release 1.10.0, we can test that the fee sharing pctg will be 80%. Do you think taiko-geth already support this?

Maybe we should also change gasIssuancePerSecond to a much smaller value for Hekla?

@dantaik dantaik marked this pull request as ready for review October 28, 2024 02:58
@davidtaikocha
Copy link
Member

Its supported.

Copy link

openzeppelin-code bot commented Oct 28, 2024

chore(protocol): change Hekla base sharingPctg to 80%

Generated at commit: 58906def64094b8303ab029ea0ca0676a2feef31

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
7
43
56
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik changed the title chore(protocol): change Hekla base sharingPctg to 80% chore(protocol): change Hekla sharingPctg to 80% & gasIssuancePerSecond to 1000000 Oct 28, 2024
@dantaik dantaik merged commit 75feb5b into main Oct 28, 2024
6 checks passed
@dantaik dantaik deleted the hekla_basefee_share_to_80% branch October 28, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants