Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): allow local.params.parentMetaHash to remain as 0 #18451

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Nov 6, 2024

Previously if this parameter is zero, we set it to parent's hash, now we simply use 0. This will avoid a SLOAD for many blocks.

@davidtaikocha @smtmfft will this be a breaking change for client or prover? Note now the metadata may have parentMetaHash as 0.

Screenshot 2024-11-06 at 12 21 02

@dantaik dantaik requested a review from davidtaikocha November 6, 2024 04:20
@dantaik dantaik marked this pull request as ready for review November 6, 2024 04:20
@dantaik dantaik requested a review from smtmfft November 6, 2024 04:20
Copy link

feat(protocol): allow local.params.parentMetaHash to remain as 0

Generated at commit: 76953e243a5303b954d0223c53a47db0af35ea3e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
7
42
55
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@davidtaikocha
Copy link
Member

Don't think its a break change for client, but might break zk cc @smtmfft

@smtmfft
Copy link
Contributor

smtmfft commented Nov 6, 2024

we get parentMeta from blockpropose event, should be the same I think

@dantaik dantaik added this pull request to the merge queue Nov 6, 2024
@dantaik dantaik removed this pull request from the merge queue due to the queue being cleared Nov 6, 2024
@dantaik dantaik merged commit 94185fe into main Nov 6, 2024
13 checks passed
@dantaik dantaik deleted the local.params.parentMetaHash branch November 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants