Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): make TaikoL2Deprecated ABI go-ethereum compatible #18659

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

davidtaikocha
Copy link
Member

If those parameters and return values don't have names, go-ethereum's abigen will create different Go bindings.

Copy link

openzeppelin-code bot commented Dec 27, 2024

feat(protocol): make TaikoL2Deprecated ABI go-ethereum compatible

Generated at commit: 69aa57091c161f936c3976b1d3795664c0577298

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
3
3
0
7
41
54
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik disabled auto-merge December 27, 2024 05:11
@dantaik dantaik enabled auto-merge (squash) December 27, 2024 05:12
@YoGhurt111
Copy link
Contributor

In Solidity testing, functions containing assertions (assert, require, assertTrue, etc.) cannot be marked as view or pure

@dantaik dantaik merged commit 05594cf into main Dec 27, 2024
6 checks passed
@dantaik dantaik deleted the TaikoL2Deprecated-geth branch December 27, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants