Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usage of //go:notinheap pragma #21

Open
cuonglm opened this issue Aug 19, 2022 · 1 comment
Open

Drop usage of //go:notinheap pragma #21

cuonglm opened this issue Aug 19, 2022 · 1 comment

Comments

@cuonglm
Copy link

cuonglm commented Aug 19, 2022

In go1.20, //go:notinheap pragma will be removed, see mode details at these CLs stack: https://go-review.googlesource.com/c/go/+/421878

//go:notinheap was first introduced for using internally in runtime package only, user code should not rely on this. There're number of places are using //go:notinheap in https://github.com/inetaf/wf/blob/2db5c3d6461ca87de5e8bb3644858c02ad0dae7a/types.go

We should remove them.

@danderson
Copy link
Member

This is pretty unfortunate. Lodged a complaint/plea at golang/go#46731 (comment) , as those annotations saved me multiple times from really hard to debug crashes and misbehaviors in this library.

In theory, there's no immediate consequence to removing the annotations from this code, other than reintroducing a footgun that the annotation completely eliminated. In practice that probably just means I'll start declining third-party PRs more due to the extra review burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants