You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is pretty unfortunate. Lodged a complaint/plea at golang/go#46731 (comment) , as those annotations saved me multiple times from really hard to debug crashes and misbehaviors in this library.
In theory, there's no immediate consequence to removing the annotations from this code, other than reintroducing a footgun that the annotation completely eliminated. In practice that probably just means I'll start declining third-party PRs more due to the extra review burden.
In go1.20,
//go:notinheap
pragma will be removed, see mode details at these CLs stack: https://go-review.googlesource.com/c/go/+/421878//go:notinheap
was first introduced for using internally in runtime package only, user code should not rely on this. There're number of places are using//go:notinheap
in https://github.com/inetaf/wf/blob/2db5c3d6461ca87de5e8bb3644858c02ad0dae7a/types.goWe should remove them.
The text was updated successfully, but these errors were encountered: