Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Go linter to GitHub Actions #890

Closed
mlabouardy opened this issue Jul 10, 2023 · 5 comments
Closed

Integrate Go linter to GitHub Actions #890

mlabouardy opened this issue Jul 10, 2023 · 5 comments
Assignees
@azgcloudev
Labels
enhancement New feature or request feature good second issue Good for seasoned contributors

Comments

@mlabouardy
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
After integrating golangci-lint into Komiser CI/CD we realized that the action takes a lot of time and runs into timeout after 5mins.
@mlabouardy mlabouardy added enhancement New feature or request feature good second issue Good for seasoned contributors labels Jul 10, 2023
@azgcloudev
Copy link

I will check this one @mlabouardy

@mlabouardy
Copy link
Collaborator Author

I will check this one @mlabouardy

assigned, thanks :)

@asamirr
Copy link
Contributor

asamirr commented Oct 8, 2023 •
edited
Loading

Do we need to fix golangci-lint or are we open to using different ones? I was messing around with my fork and tried Go-lint and I think it works. A bit too aggressive with its checks though. Check my run here

@Azanul
Copy link
Collaborator

Azanul commented Oct 8, 2023

Do we need to fix golangci-lint or are we open to using different ones? I was messing around with my fork and tried Go-lint and I think it works. A bit too aggressive with its checks though. Check my run here

I think we should stick with golangci-lint, since it is the standard.

@Azanul
Copy link
Collaborator

Azanul commented Mar 5, 2024

I think this has already been resolved

@Azanul Azanul closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azgcloudev azgcloudev

Labels
enhancement New feature or request feature good second issue Good for seasoned contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@asamirr @mlabouardy @Azanul @azgcloudev