Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters bar & filters' style don't match the design #935

Open
AllieMendes opened this issue Sep 5, 2023 · 14 comments
Open

Filters bar & filters' style don't match the design #935

AllieMendes opened this issue Sep 5, 2023 · 14 comments

Comments

@AllieMendes
Copy link

Describe the bug
Here is a list of inconsistencies found:

  1. The "Add Filter" button's icon doesn't match the designs and doesn't seem to be using our icon library.

Implementation:
image

Figma reference:
image

  1. The filters bar has a "Filters" title before the filters that shouldn't be there.

Implementation:
image

Figma reference:
image

  1. The filter's margins don't follow the ones set on the Figma component; the icon stroke is thinner than it should; the close button doesn't match the design.

Implementation:
image

Figma reference:
image

  1. The add filter button (after a filter has already been added) is not really a button and doesn't match the one on the Design System.

Implementation:
image

Figma reference:
image

  1. The divider between the filters and the "Clear filters" button's color doesn't match the design.

Implementation:
0 solid #e5e7eb

Figma reference:
image
1px solid #edebee

  1. The "Clear filters" button doesn't match the design — it should be a text button with an icon (the button states are all documented on the Design System).

Implementation:
image

Figma reference:
image

Additional context
If you want to tackle this task, feel free to share with us your email address so we can give you access to the Figma project :)

@AllieMendes AllieMendes added the bug Something isn't working label Sep 5, 2023
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Hey, thank you for opening your first Issue! 🙂 While a Tailwarden team member takes a look at your issue we would like to invite you to join our official Discord server, where you can interact directly with other contributors and Tailwarden team members. Link here: https://discord.tailwarden.com

@mlabouardy mlabouardy added good first issue Good for newcomers ui and removed bug Something isn't working labels Sep 6, 2023
@sajdakabir
Copy link

Hey @AllieMendes I would like to work on this issue. Can you assign it to me?

@mlabouardy
Copy link
Collaborator

Hey @AllieMendes I would like to work on this issue. Can you assign it to me?

all yours @sajdakabir

@sajdakabir
Copy link

sajdakabir commented Sep 26, 2023

Hey @mlabouardy Can you please give me Figma assess

@AllieMendes
Copy link
Author

AllieMendes commented Sep 26, 2023

Hey
I've sent an invitation @sajdakabir!

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Sep 27, 2023

@sajdakabir just as a heads-up, we just introduced the dependency-graph which is re-using some of the inventory filters. You can see the changes here. I hope it can be merged soon!

Screenshot 2023-09-27 at 16 52 48

Ping me if you have any questions regarding my changes 🙏

@sajdakabir
Copy link

Hey @AllieMendes, Can you please help me with the below error?
Screenshot 2023-09-29 at 11 33 01 PM

To run the server I have flowed https://github.com/tailwarden/komiser/blob/develop/CONTRIBUTING.md#how-can-i-contribute-to-komiser-dashboard .

@AvineshTripathi
Copy link
Collaborator

I think you have not started the server, if not please create a config.toml and then in komiser dir run go run *.go start --config="./config.toml". Let me know if this works

@sajdakabir
Copy link

After running go run *.go start --config="./config.toml" I am still getting the same error.

Screenshot 2023-09-30 at 12 49 29 PM

@Azanul
Copy link
Collaborator

Azanul commented Sep 30, 2023

After running go run *.go start --config="./config.toml" I am still getting the same error.

Screenshot 2023-09-30 at 12 49 29 PM

On which port does your server start? How are you starting the UI?
In NEXT_PUBLIC_API_URL=http://localhost:3000 npm run dev, the value of NEXT_PUBLIC_API_URL should be the server url.

@sajdakabir
Copy link

It's working now. Thank you @Azanul and @AvineshTripathi

@AllieMendes
Copy link
Author

Hey @sajdakabir, any update on this issue?
Let me know if you have any questions!

@sajdakabir
Copy link

Hey @AllieMendes, Please pass it to another one.
I am busy with something else.

Thank you.

@AllieMendes
Copy link
Author

Thank you for the update @sajdakabir!
I'll unassign you then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants