Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Touch event does not close an open Popover on iOS #1173

Closed
ddahan opened this issue Mar 1, 2022 · 4 comments · Fixed by #1175
Closed

[BUG] Touch event does not close an open Popover on iOS #1173

ddahan opened this issue Mar 1, 2022 · 4 comments · Fixed by #1175
Assignees

Comments

@ddahan
Copy link

ddahan commented Mar 1, 2022

What package within Headless UI are you using?
@headlessui/vue

What version of that package are you using?
v1.5.0 (with Vue v3.2.26)

What browser are you using?
Chrome/Safari on iOS

Reproduction URL
https://stackblitz.com/edit/vue-ykt4oa?file=src/App.vue

Describe your issue
When using a simple headlessUI Popover component:

  • On desktop (macOS + all major browsers), it works as expected: when I click outside the open popover, it disappears.
  • However, on iPad/iOS (tested with Chrome and Safari), when I touch outside of the open popever, it does NOT disappear.

I made a stackblitz to show the issue (to be opened with an iOS touch device to actually see the issue)

Additional notes

  • The issue is similar if I use a Menu component.
  • I'm already aware of this similar issue but decided to create a new one as it may not be the same case since the OP has resolved its issue by upgrading to a new Headless UI version, not me.
@oberocks
Copy link

oberocks commented Mar 1, 2022

I can second this one with @ddahan . Have confirmed this issue to exist/persist on iPad iOS and iOS Safari.

@oberocks
Copy link

oberocks commented Mar 1, 2022

@ddahan PS - just so it's not missed and in case you are still having trouble - pls see a fix for your Popover/v-click-to-close situation #919 (comment)

@RobinMalfait
Copy link
Member

Hey! Thank you for your bug report!
Much appreciated! 🙏

This should be fixed, and will be available in the next release.

You can already try it using:

  • npm install @headlessui/react@insiders or yarn add @headlessui/react@insiders.
  • npm install @headlessui/vue@insiders or yarn add @headlessui/vue@insiders.

@sornt
Copy link

sornt commented Mar 29, 2022

@RobinMalfait Thank you so much. It is working!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants