Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Component Accessibility - aria-controls Value Issue in React 17 #2882

Closed
helmisatria opened this issue Dec 14, 2023 · 1 comment · Fixed by #2883
Closed

Tabs Component Accessibility - aria-controls Value Issue in React 17 #2882

helmisatria opened this issue Dec 14, 2023 · 1 comment · Fixed by #2883
Assignees

Comments

@helmisatria
Copy link

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

v1.7.17

What browser are you using?

Chrome, Edge

Reproduction URL

Steps to Reproduce:

  • Use the Tabs component in a React 17 project.
  • Observe the aria-controls attribute of the tab buttons.

Describe your issue

I've encountered an issue with the Tabs component from the @headlessui/react where the tab's aria-controls value is set incorrectly (id is undefined) when used with React 17. This issue seems to be specific to React 17 and does not occur in React 18.

Screenshots:
image
image

@RobinMalfait
Copy link
Member

Hey!

This has been fixed by #2883 and will be available in the next v1.7 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants