Fix vue TypeScript declarations #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The declarations generated by tailwindlabs#254 aren't correct, leading to tsc errors as seen in tailwindlabs#318.
|
Can this be merged? currently blocked by this issue when using tailwind UI components... |
|
The import("vue") should work normally. It always worked for me and others with Vue3+Vite+TS setups. There must be another issue why this happens. |
|
@VottusCode I've created an example repository here that reproduces the problem: https://github.com/SniC/heroicons-vite-typescript-problem |
|
Thanks for this! I think it should be |
This was referenced Sep 11, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declarations generated by #254 aren't correct, leading to tsc errors as seen in #318.