Fix vue TypeScript declarations, again #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenderFunction has the wrong signature, causing
error TS2786: '...' cannot be used as a JSX component.
Its return type 'VNodeChild' is not a valid JSX element.
Type 'undefined' is not assignable to type 'Element | null'.
as documented in tailwindlabs#516.
This commit reverts 1658f7c.
|
Actually upon further investigation, |
|
@zmwangx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why
DefineComponentwas changed toRenderFunctionin #322, but it has a wrong signature (returnsVNodeChildinstead ofVNode) and is now causing #516 with newer versions ofvue-tsc(allegedly, I didn't downgrade it to check):as documented in #516. So here we change
RenderFunctionback toDefineComponent.