Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for plugins repo #258

Open
daywalker90 opened this issue Jun 7, 2024 · 0 comments
Open

Tests for plugins repo #258

daywalker90 opened this issue Jun 7, 2024 · 0 comments

Comments

@daywalker90
Copy link
Contributor

Hi, we'd like your tests for the cln plugin to run in the plugins repo so users can see in our new table if your plugin still works for the current cln version. Plugins without tests or failing tests will be moved to the archived section soon.

This project is a little special as usually we add the plugin as a submodule to the plugins repo and search it for tests to run. But since this repo contains the plugin in a sub-directory we need to get a little creative.

Good news is that i already tried your tests + very minor updates and they passed for cln 24.05! I'll open some PR's for that asap.

What we could really need are some release binaries for the cln plugin (and teos since its a dependency for the tests), because we really like to avoid compiling plugins in the plugins' repo CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant