From cda9a9dc207d48121b2752bf857f2bc4e2c7d9bf Mon Sep 17 00:00:00 2001
From: alpharush <0xalpharush@protonmail.com>
Date: Mon, 29 Jan 2024 15:44:25 -0600
Subject: [PATCH] fix: detect selfdestruct in internal calls (#2232)

* fix: detect selfdestruct in internal calls

* update snapshot
---
 slither/detectors/functions/suicidal.py       |   2 +-
 ...etector_Suicidal_0_7_6_suicidal_sol__0.txt |   2 ++
 .../test_data/suicidal/0.7.6/suicidal.sol     |   8 ++++++++
 .../suicidal/0.7.6/suicidal.sol-0.7.6.zip     | Bin 1478 -> 1918 bytes
 4 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/slither/detectors/functions/suicidal.py b/slither/detectors/functions/suicidal.py
index 1f8cb52f9c..f0af978ec7 100644
--- a/slither/detectors/functions/suicidal.py
+++ b/slither/detectors/functions/suicidal.py
@@ -59,7 +59,7 @@ def detect_suicidal_func(func: FunctionContract) -> bool:
         if func.visibility not in ["public", "external"]:
             return False
 
-        calls = [c.name for c in func.internal_calls]
+        calls = [c.name for c in func.all_internal_calls()]
         if not ("suicide(address)" in calls or "selfdestruct(address)" in calls):
             return False
 
diff --git a/tests/e2e/detectors/snapshots/detectors__detector_Suicidal_0_7_6_suicidal_sol__0.txt b/tests/e2e/detectors/snapshots/detectors__detector_Suicidal_0_7_6_suicidal_sol__0.txt
index 4a784217df..99a6a0295f 100644
--- a/tests/e2e/detectors/snapshots/detectors__detector_Suicidal_0_7_6_suicidal_sol__0.txt
+++ b/tests/e2e/detectors/snapshots/detectors__detector_Suicidal_0_7_6_suicidal_sol__0.txt
@@ -1,2 +1,4 @@
+C.i_am_a_backdoor2(address) (tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol#8-10) allows anyone to destruct the contract
+
 C.i_am_a_backdoor() (tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol#4-6) allows anyone to destruct the contract
 
diff --git a/tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol b/tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol
index 428c794d4d..31b22d767a 100644
--- a/tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol
+++ b/tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol
@@ -5,4 +5,12 @@ contract C{
         selfdestruct(msg.sender);
     }
 
+    function i_am_a_backdoor2(address payable to) public{
+        internal_selfdestruct(to);
+    }
+
+    function internal_selfdestruct(address payable to) internal {
+        selfdestruct(to);
+    }
+
 }
diff --git a/tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol-0.7.6.zip b/tests/e2e/detectors/test_data/suicidal/0.7.6/suicidal.sol-0.7.6.zip
index 635092d49ecdda4ce21c4da09b8ba5b061e9a72e..ecd80364b245bf08dcb196de7486ec55a28df991 100644
GIT binary patch
delta 1676
zcmV;726Oqw3;qrpP)h>@KL7#%4gd+iZda<nC6U|)007`6001D9jRhl-KB<4Q$u?Rz
zI}?pqkHp>}*4ZQcwI)f^lUKiXxlVyu|ACX92r)}MHOg=ndqYlx*~+h_@%>JJ&~x?e
zB8z#op}$%%#&@A;RgU@Rrr1v#lR}i~4>{M%N>GzFjX(CFvp<h^hQi>bQoa3{wcR#}
zmeTK!Cxr%@F0FnHuvc362W@}%_eX;nII?MS0MrIPVJ@-KDVoo`JFmJU3?!rEflC_U
zYTq@FHa5*0`)GgRY^d0>57pCPCbmYO=&3YN#{$u){#$h$nCE~Ex}qrSA4KJm83p|*
z?YKSyiz5ZE&<DIG6`oc~+MO#MnCR9M9NHPn3|z+|XsD?E6xRGrX<dIw3RGYs2B7(u
z>JN6-+Z4lbKo7{djAz(EF5{FYoqb`<wtX)HcNp;NvSdDc7HnoPk-u8RT9@0qG{@lt
zJ0x2(QfZ8698|)%Qx5N>NvO395Czu*KYH&W{(m4>6YNCgt@7U{4r6ocI<=z0(!Jwv
zAloCKXWo9%31PfDKS+PPb0Bq%w1dWAmEAUXI&+G$Y}4ceqZwuYZPo6`8tv@%FB?tk
z0C{C8PtEf}b8%Qs1HCnqDsx+cR^FY!1`MRN+Yitp0`W;FMIJbQVZy34=7aBUqdwZE
zCOMLN#>{?>B-81ABfdc1InZUQVCxOoS;#&9FI~LKwB@mR><WKjuIW1$R;)|9TwjAF
zj7WDHW_vv%H^ss%V00O=>1Ut%hnnM@@WQZhANXO!Z#VV3fqjNF9$7dl<5jOSPB=mv
zww^el)k9`zOYo>EhjRKqZ1*@o`xW2kG@@&qD*z(lmy2HeJD+tC{&Z3XdCYxH)D9}a
zma2&s4;qRD1O0yqs~Ami+MTlW!=7Aye(CJQopm>-PHiT?Dmva5JoJu3rwOb}f$gjO
z^8kNPjvM|qH6_8@GP3u77;s)$41+1;hY{`YfnK^3(+YRpE+U;JehNr;$wpqN<;!>1
z{Of*a{N{rG=y1pD*cOo;afKQI#<SXM6FtQpQ|g`s5m$e|qnbiw!Q1>EXz8|jQp2OE
zSHD>T2&j|kV11gZ_Wv+RUb3v3aw6!+D?TWjQ>oNs3d@#}S=dIfaFkkjcIit|Az0w{
z4$kXjZ*x!5wvQimQyDwx6NaeX)^RIV7g^QWIX#jC5bm7q*5ageZ_j<LeubYU=D(!T
z9I%QDi4}j>4F%VapRVeK=Gknl<#hRfyqrgfgRy$RzKe86-<AU1LyR%+$FX`|H>%U4
zKy^7)>xTfY)(pVQ_zNx!$Y588tV~wNzxwG<K$|-NJkAf~kWC3V;X>$mOY2%(-=c|I
zxpn<zCuKMJ3m~>D7zk?t4cZi1@M!fHVt^}TP5OT-p1`QAYXw)@>lFXwe->TG@xKlY
z@P)4FOh#yS8QPkpxi=kr)lG0?__jg>wE@izk8_W@x$0toGF6VGtFOYJ{g*@1@YZhi
z#di8L!XvPA{k!ywLY}<tbx?>fKV4c0$k8<}(|ujhO?32XSyhJyYe*g~Vd55(xxq$f
z9YlZZ37juY^iZ){)SJj<%dn6TV8b6+ml(=G+nI({{oi952&b<zpP`ixW3IokP?U)p
zYglm1va<^DLJU}%(c*;>Oj#9$J;PR#gd6a$M|R@vuPXR4BmGEt$wRfqf@Z$$b-0Vz
zP#~f#X9Boss)|_)#yT6vO_m2QS~Slkj>LZx8KYV2w9>chDi))(J+cd@Be)3qLdAi~
zrS3F<Vico9M^GHRKigQrsP(SAu%Cky4lI&hi3!$WPvD6y>P9~}Likz3-VzDjnqykc
zxTb9pn4*WqHkQj4w6mjyJwccq(C*0PU5fEUwXo9y1N{FlVI$K2@Q}3&apO_1Du#c{
zv!KpH^s^dzo{=1`;)nvq138^zRu75s1aOuA4cBQ%f4$0FvQqX5e)~z$NJe;bkZ6WK
z5s<`mD7wa=S$Rk4b*lLRX#=U*2VOmr%R>qZ8V!rZ<sdBHwq+=fA$}Y_DYf`<f}PuV
z%sly;$~GZxu|mgngsmPibZYSlS3z0eX79)~9F&oL!fa$3r7zd}LU;{hrwvF-cY4UM
z?^wfr+wS}WaPIZ^K$ce|Rxc3KabTy?iSIw$zpect!{<;-0Rle*KL7#%4gd+iZda<n
WC6U|)007`6lY9k41{wzd0001IdNX<e

delta 1226
zcmV;*1U38q4#o=@P)h>@KL7#%4gfQacUDm|1vn%H0012mkr>Z^t>?SvX?p7Dh;w36
z@yXD87z=#tMF0So=QQCRp0K@Q(TGGPCl1U{6^Nxy9(#xgVo4QZ4n`GPH2%(uKMNZ<
zX>M?Bb_4*Kd%)Ml6ruYCkOuUV!(@e3`sp=&qLytSTIn3hVM7t~EuR7j<ve`9NqPKx
z^a`hfmNAg`V1UMd$iMDeQA4z8ce&TEmU3QUs2BTfzbf#QuWjQw`hfd!7qqms{C}N*
zS$bu<snU|ZJ>Zy${w0|l7qSlpoJP_QVGsOIqM2p;XduV`05(PhsER9^^PB1$!1IyT
zmeWoQZ(c~q1eI`)jITj$*6uom#c@mxymrdtLSm0{{a0Rp$~rX^eJMc2^J(V<vd$CD
zSBj(m=H;?i0YXOR9rUVJ!O!D?Ww&a6=G5vRx=(p0A5IYNu?UF=7(fwenk-$9i{;Rq
zWhrCWZ^k{6|5?oaqzdu-h=_PjPMN(YKklE0s4sn@91j<t+e6t)ujkoBVCt>(1-<zd
zg&Cq7bXvTBWzSdHvk<vq3{<|a05Ku7ciAW%P|}^^m0l4!(mIg3*Ut}imy<Mox`%d`
zF+UF~=mR@zn35@XJNDbmlVsNJ!?PShvSPRV7zS}NvpSgRK$cwn481{gk=5)H$fvNO
zIL^&=yWoRo86J9r&{PJdQ`aCsJ1zHfGaJ#ykM3oE6h3i(^l6?IjS3kCYPvR3z}3^*
zY67%w2C;!Qbf6BZxzX3M2d8BU+tj!h9<=uMxHx1oa2W+^ABrBDO#K0N`fmJngc5)2
z(4`~M%2`aO!dJHMXMXD87OwlI=E9w=pywn3D1XSBepVAVn$<wQ8$#AS?XWA}V2dc#
z5AjBScjR_Tpd1cY5AWlVnRH`~85Fw%W6-SFtZV!KWkw&R^pfA_;B3DVFo%91sny2e
zDn9zbVXg8IL~`a%n<M2eReZi-f{y&d>HSaiNhZ=D?Q^z-$6h$Rg(I%(dC8~e)F+pD
zPf5<r54AIb`Z^xNR`nZ({g897jjxzCf#Gw1vDh2Sd&K;LD!s}ErI_qZy&Z-BnuwrH
z7wn`lp|Ooce+2MiTbSYo--cl*2|#Oq_kzi0Edgq&1-s!5{9y$7FTHQg=Kso%Ej^aC
zR^wwyoEr1A96;rd20*z+iaXU2mZC(;t(pI^LolA^1Xu;{zZbkkkHhT*I9?YaX@p9D
z|1MyhENd64Et)vGdki#HFAUsXXacVL5%__I@^hTw$52Nj?>vrsxF(QL=9be2%7JX(
zt_wQh8yVd1FV3A2c)@5>1VRpy0pV9x=y9Bz$8${$P|x^XADgfSn-ayRAz9UNz<Zz}
zrZf1>_s1AhhwVqQ;-7KLj(C+GJwz0L6@l<3dO>dei$PFH7PrPFZm9WW?xHTSBNmbV
z;;D-)9{8ml4Ymd<p+|Tpv4rh%yM&jeg*#pPz<OOplH5Hx+M$ccsSx{ya#c=GT|@a!
zowKjH+5I?tg<lP$!~~+t?ND&Y*47ni46s=W#@;h`a<n6=0bA~XfjBJ}h3=#t{h+@w
oP)h*<KLbAi0ssyGGmUpvQ8NWNBn1Ef9TSr@2Sf&91poj501U}dfdBvi