chore(pubsub): clean up log messages #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaundialpad
approved these changes
Dec 15, 2022
Main goal: ensure that `hash(message)` is useful: eg. that log messages can be relied on to be constant for cases where it is "the same error" and different for cases where it is not. This allows for clients to do things such as alert when the rate of a given error message is above a given threshold. While I was here, I cleaned up the other log strings in the file to make 'em all consistently typed/formatted/etc.
TheKevJames
force-pushed
the
kjames/pubsub-logging
branch
from
7d63398
to
852c49c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal: ensure that
hash(message)is useful: eg. that log messagescan be relied on to be constant for cases where it is "the same error"
and different for cases where it is not. This allows for clients to do
things such as alert when the rate of a given error message is above a
given threshold.
While I was here, I cleaned up the other log strings in the file to make
'em all consistently typed/formatted/etc.