feat(pubsub): improve logging #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve some logging: * move some info logs to debug, as they're generally just noise for most users * avoid logging requested shutdowns as warnings, and log unexpected ones as errors
shaundialpad
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Makes sense in theory! These were definitely nice to have when we were debugging issues with GKE pods receiving multiple kill signals and the subscriber getting doubly cancelled (doesn't appear to be happening any longer from what I can tell) and other oddities, but if we ever need to dig into this again I suppose we can always manually enable it.
pull bot
pushed a commit
to tj-python/gcloud-aio
that referenced
this pull request
Apr 4, 2023
Improve some logging: * move some info logs to debug, as they're generally just noise for most users * avoid logging requested shutdowns as warnings, and log unexpected ones as errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve some logging:
users
as errors